search

elixir-europe / MARS

Multi-Repository Data Submission using ISA-JSON
MIT License
5 stars 4 forks source link

add credential management #6

Closed xiaoranzhou closed 5 months ago

xiaoranzhou commented 6 months ago

credential management using prompt and keyring

bedroesb commented 6 months ago

@xiaoranzhou thanks a lot for this addition. We might want to first decide how we handle multiple credentials for multiple repositories.

How would you implement this with your method based on the username (if I understand things correctly :) )? I see a use in the env variables but a prompt looks counter intuitive for the implementations we are looking into I think (Galaxy, ARC, different webbapp or even a CLI because than putting it in a pipeline become less easy) .

xiaoranzhou commented 6 months ago

@xiaoranzhou thanks a lot for this addition. We might want to first decide how we handle multiple credentials for multiple repositories.

How would you implement this with your method based on the username (if I understand things correctly :) )? I see a use in the env variables but a prompt looks counter intuitive for the implementations we are looking into I think (Galaxy, ARC, different webbapp or even a CLI because than putting it in a pipeline become less easy) .

Yes, this is a collection of options we could have. Including environment variable, prompt and system secret management. We should provide many ways to store credential. We need to decide the priority of the three methods and the pipeline to check or let user decide which one to use.

bedroesb commented 5 months ago

I will merge this pull request so it can be used as starting point later on. We should keep in mind it is not yet "integrated" after this merge. Thanks @xiaoranzhou !