elixir-europe / faircookbook-rdmkit

This repository will in the first place be used to link pages between FAIR Cookbook and RDMkit.
MIT License
4 stars 4 forks source link

Automatic title update faircookbook_rdmkit_mapping.yml #23

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This PR is automatically generated based on title changes on FAIRCookbook or RDMkit.

Please verify if these changes are valid.

bedroesb commented 1 year ago

@tabbassidaloii Doing some tests locally I noticed that some titles were not being updated, due to some little bug, resulting in no title updating.

A question towards the rest: Are we ok with the use of sidebar titles as title? Before it used to be the page title, which is different from the sidebar .....

floradanna commented 1 year ago

@bedroesb do you refer to sidebar titles and page title of RDMkit pages or FAIR Cookbook recipes?

bedroesb commented 1 year ago

@floradanna The titles for the mapping file will be/are taken from both sidebar files.

Before the creation of this bot, titles were taken from the page. In RDMkit the sidebar title and the page title is in most cases the same. This is why this PR looks like it only applies for FCB, were there are more differences (not always).

floradanna commented 1 year ago

I don't know pros and cons of the two options. I would say to use the most "stable" one, that might be sidebar title? I don't know.

bedroesb commented 1 year ago

Sidebar is more stable and is shorter. Don't know if that last one is a pro or a con.

proccaserra commented 1 year ago

Tx for the PR but can you reopen on the dev branch please? 🎉

bedroesb commented 1 year ago

@proccaserra This is an automatically created one by the bot, until now we don't work with a dev branch since there is not really development or a release cycle ....

bedroesb commented 1 year ago

Wohoow!