elixir-europe / infectious-diseases-toolkit

Infectious diseases toolkit
https://www.infectious-diseases-toolkit.org/
Other
9 stars 38 forks source link

Change all URLs to use hyphens #119

Closed bedroesb closed 1 year ago

bedroesb commented 1 year ago

This will close #115 .

As discussed in the editorial meeting, we would move towards the use of hyphens in the url.

Please check if everything works including the changes from #118 and #117 here: https://bedroesb.github.io/infectious-diseases-toolkit/ :sparkles:

WARNING: Merge this PR after #117 and #118 is merged

TODO after merge:

bedroesb commented 1 year ago

Currently the page_ids and sections in the related pages are still with underscores. Do we want to keep this distinction?

martin-nc commented 1 year ago

https://bedroesb.github.io/infectious-diseases-toolkit/pathogen-characterisation/ is broken for me (from the side menu), Also:

Some of these could be the quirks of your local fork, I guess. You could try running the W3C link checker on your fork: : https://validator.w3.org/checklink?uri=https%3A%2F%2Fbedroesb.github.io%2Finfectious-diseases-toolkit%2F&hide_type=all&depth=&check=Check

As for the page IDs - will people have to use them? If so, maybe it's simpler to using the same convention. Are page IDs needed, incidentally? In the RDMkit, didn't we talk about using the page slug (url fragment)?

bedroesb commented 1 year ago

@martin-nc Good catch, many of these footer links are also not working on the real website 🙈 Concerning page_ids, yes that is my wish, on the RDMkit and here, but currently not yet the case...

bedroesb commented 1 year ago

lets gooo