elixir-europe / infectious-diseases-toolkit

Infectious diseases toolkit
https://www.infectious-diseases-toolkit.org/
Other
8 stars 33 forks source link

Belgium national page #157

Closed ShonaCosgrove closed 11 months ago

ShonaCosgrove commented 1 year ago

Have filled in the 'national tools and resources' and 'training resources' from the excel sheets but I get this message: Error in user YAML: (): mapping values are not allowed in this context at line 11 column 40.

How can I fix this?

bedroesb commented 1 year ago

Hey!

A tip for filling in the metadata is copying the chunk of content between the --- lines and checking it with this validator: https://codebeautify.org/yaml-validator

Here I can see for example that there is a colon in you key-value pair:

training:
  - name: Master of Biomedical Sciences: Infectious and Tropical Diseases

This can be solved with

training:
  - name: "Master of Biomedical Sciences: Infectious and Tropical Diseases" 
bedroesb commented 1 year ago

I know, this is not user friendly :D it bothers me too that it is this way ... I should add this validator to the documentation.

bedroesb commented 1 year ago

Seems to look good now! https://shonacosgrove.github.io/infectious-diseases-toolkit/national-resources/belgium

ShonaCosgrove commented 1 year ago

Ok thanks Bert! I've just marked it for review :)

bedroesb commented 1 year ago

@ShonaCosgrove I don't remember if the comments of Patricia were already applied, or still living in a google doc? :) Although maybe Sciensano biased, I do personally think it would be nice if the Belgian page could go life, don't know, my opinion :)

ShonaCosgrove commented 1 year ago

Hey @bedroesb, the comments from Patricia have been applied in the Google doc for now. I agree that it would be good to get the page up! I can make the changes in GitHub this afternoon

ShonaCosgrove commented 1 year ago

Hey @bedroesb, I made the changes now in the Belgium page, hoped it worked ok and we can publish :)

bedroesb commented 1 year ago

looks good!