search

elixir-explorer / adbc

Apache Arrow ADBC bindings for Elixir
https://arrow.apache.org/adbc/
Apache License 2.0
50 stars 16 forks source link

WIP - Update Apache Arrow ADBC to 0.8.0 #42

Closed Cowa closed 11 months ago

Cowa commented 11 months ago

I need one of the new features from the version 0.8.0 so I tried to update it myself.

It's not tested as I can't get it to compile: Capture d’écran 2023-11-24 à 10 53 13

checksum.exs seems to be required but is not versioned so I tried to remove it from package() but it still shows the error.

Any idea how to fix it? Thanks!

cocoa-xu commented 11 months ago

Hi @Cowa! Thank you very much for the PR.

checksum.exs seems to be required but is not versioned so I tried to remove it from package() but it still shows the error.

Any idea how to fix it? Thanks!

It's okay that checksum.exs is missing because it will automatically fallback to compiling from source. The issue in your system was that there was no cmake installed on the system. Sicne this project will use cmake to build C++ source files, this will lead to a fatal error. Install cmake should fix this issue. :)

Cowa commented 11 months ago

Thank you, I was missing cmake :)

In my branch when I run make it works. But somehow in Livebook the compilation still fails with the same error 🤷‍♂️

josevalim commented 11 months ago

IF you are using Livebook via the desktop app, it does not have access to your PATH. You need to configure the PATH in settings. :)

josevalim commented 11 months ago

Thank you @Cowa! I have updated it locally. The reason I did so is because, for external contributions, I always need to review all code to ensure there was no modifications, so in this case it is easier for me to do the update myself. Feel free to ping us next time. :)

Cowa commented 11 months ago

No problem I understand, thank you both of you for your help and your reactivity! :)

josevalim commented 11 months ago

v0.2.2 is out!