search

elixir-explorer / adbc

Apache Arrow ADBC bindings for Elixir
https://arrow.apache.org/adbc/
Apache License 2.0
50 stars 16 forks source link

return `Adbc.Column` #70

Closed cocoa-xu closed 5 months ago

cocoa-xu commented 5 months ago

This is a follow-up PR of https://github.com/elixir-explorer/adbc/pull/68.

cocoa-xu commented 5 months ago

Currently it supports both primitive and complex data types in results. I'll send another PR for binding parameters with complex data types using Adbc.Column.

cocoa-xu commented 5 months ago

Looks great! Two minor comments and we can ship it!

Thanks for the code review Jose!

And I applied a minor change so the users can use seconds and milliseconds in Adbc.Buffer.date{32,64} (commit 3929a65) respectively. This should match the semantic defined in the arrow format, tdD and tdm