search

elixir-explorer / adbc

Apache Arrow ADBC bindings for Elixir
https://arrow.apache.org/adbc/
Apache License 2.0
50 stars 16 forks source link

added support for dictionary and fixed bugs #95

Closed cocoa-xu closed 4 months ago

cocoa-xu commented 4 months ago

This PR fixed some bugs and added support for encoding and decoding dictionary types.

josevalim commented 4 months ago

I don't know if we talked about this, but should it be s8, s16, etc for consistency with Nx and Explorer?

cocoa-xu commented 4 months ago

I don't know if we talked about this, but should it be s8, s16, etc for consistency with Nx and Explorer?

Oh we haven't but I can change them in a minute! Should we keep the old ones for compatibility or just rename them and make it a breaking change?

josevalim commented 4 months ago

let's just rename them and make it a breaking change, i don't think anyone is using them yet. But we can make it in a separate PR!

cocoa-xu commented 4 months ago

let's just rename them and make it a breaking change, i don't think anyone is using them yet. But we can make it in a separate PR!

Ok I'll send a PR soon!