search

elixir-explorer / explorer

Series (one-dimensional) and dataframes (two-dimensional) for fast and elegant data exploration in Elixir
https://hexdocs.pm/explorer
MIT License
1.12k stars 123 forks source link

Fix decimal empty list bug #1015

Closed billylanchantin closed 1 week ago

billylanchantin commented 1 week ago

Fixes two things:

  1. The :decimal generator was generating Elixir-side #Decimal<>s that the Rust-side couldn't represent.
  2. There was a bug in s_from_list_decimal where empty lists failed to have the Decimal(...) dtype.

Now we can remove the decimal-related TODOs we added in https://github.com/elixir-explorer/explorer/pull/1012.

See also: https://github.com/elixir-explorer/explorer/issues/1014.

billylanchantin commented 1 week ago

Also worth noting:

EDIT: contents moved to their own issue: https://github.com/elixir-explorer/explorer/issues/1016