search

elixir-explorer / explorer

Series (one-dimensional) and dataframes (two-dimensional) for fast and elegant data exploration in Elixir
https://hexdocs.pm/explorer
MIT License
1.12k stars 123 forks source link

Add more options for cacertfile including custom file supplied by user #880

Closed GenericJam closed 8 months ago

GenericJam commented 8 months ago

The existing code was failing for me due to being behind corporate proxy.

I shamelessly borrowed most of this from here -https://github.com/elixir-cldr/cldr_utils/blob/2fcfefb729e1ff3fa06a4cb9d531846c2056bcf2/lib/cldr/http/http.ex#L330 - so if kipcole9 could get credit that would be great.

I haven't been able to verify it works due to other build issues but it has worked as far as I've been able to test it.

I'll keep trying to test it on my end and report back.

GenericJam commented 8 months ago

This works on my own machine which is not behind a proxy. I'd say it's safe to use. It's failing on my work machine which is behind a proxy due to rust build issues.

josevalim commented 8 months ago

Recent Erlang versions come with the ability to read the system store, so I think we should default to that instead. I will push a fix soon /cc @kipcole9

GenericJam commented 8 months ago

For me, it's more about trying to delegate the location of the certs than about finding them automatically. On my work computer, the company controls most of it apart from what's in ~/code so it's better for me if I can tell it where the certs are.

GenericJam commented 8 months ago

For me, the very janky work around involved copy/pasting certs into the _build folder so Explorer would find them.

GenericJam commented 8 months ago

Also a lot of corporate code is stuck on older versions of Erlang/Elixir so new fixes won't make it there for a while.