elixir-explorer / explorer

Series (one-dimensional) and dataframes (two-dimensional) for fast and elegant data exploration in Elixir
https://hexdocs.pm/explorer
MIT License
1.12k stars 123 forks source link

`{:datetime, :second}` dtype support #885

Closed LostKobrakai closed 8 months ago

LostKobrakai commented 8 months ago

Looking at the initial PR for the precision on datetimes I didn't find seconds as a unit being discussed. I'm dealing with a lit of unix timestamps and doing {:datetime, :millisecond} feels wrong given I initially don't have that much precision. Are there any reasons not to support second precision?

josevalim commented 8 months ago

If it is supported in polars, I believe we can totally support it here too.

LostKobrakai commented 8 months ago

Ah, that's where the limitation is. It only supports the 3 precisions we have it seems. I was looking at the arrow docs, which were linked on #867 and it showed second as a unit.