search

elixir-geolix / geolix

IP information lookup provider
Apache License 2.0
190 stars 18 forks source link

Read from a remote file #10

Closed acconrad closed 8 years ago

acconrad commented 8 years ago

This long-awaited PR supports the ability to read .mmdb and .mmdb.gz files from a remote address rather on your local file system.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.6%) to 97.207% when pulling 3de477a6d3512385dcf1c93a62c9f0a6033c7c11 on acconrad:master into 7554c6b90958dba7e91de55ecdef507ab282e92d on mneudert:master.

mneudert commented 8 years ago

You even made a test for it :+1:

I took your branch and made some additions to it: acconrad-master

What did I do?

Basically just one real change. And that was using :httpd to load one of already available fixture files for testing instead of an official download.

Everything else is just cleanup stuff. Like ensuring :inets is started so the http request does not fail because of that. Might not be necessary but also should not really hurt. On top of that I moved all file logic into the loader and did some cleanup to respond with a better error message when the http request fails.

If that looks good to you I would probably improve the docs a bit more and maybe squash some commits together. And then just merge what you did in the first place :shipit:

acconrad commented 8 years ago

@mneudert sounds good! Do you want to just merge your branch into this PR so we can get this out the door?

mneudert commented 8 years ago

All cleaned up and merged :heart: :yellow_heart: :blue_heart: :green_heart: :purple_heart:

mneudert commented 8 years ago

Will release a new version tomorrow if I don't find any arguments against that plan.