elixir-gettext / gettext

Internationalization and localization support for Elixir.
https://hexdocs.pm/gettext
461 stars 87 forks source link

Pass msgctxt into handling missing translation functions #304

Closed tusooa closed 2 years ago

tusooa commented 2 years ago

To resolve msgctxt not being passed into the fallback function, we added new callbacks handle_missing_translation/5 and handle_missing_plural_translation/7 that will get msgctxt. The default implementations for these two functions call the old versions respectively, so users implementing the old callbacks still get the same result.

BUG: https://github.com/elixir-gettext/gettext/issues/303

josevalim commented 2 years ago

I will investigate it then, thank you!

josevalim commented 2 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: