Closed maennchen closed 2 years ago
@whatyouhide I would really like to finish up this PR. Will you be able to have a look at the outstanding parser issue or should I try to find some help somewhere else?
@maennchen hey, sorry for the wait. I was spending my OSS cycles mostly on Xandra the past few weeks, and I have just a little more to go. I would be able to take a look at this in something like a couple of weeks, would that works? If I'll get to it sooner, I'll get to it sooner 😄
@whatyouhide Thanks for the feedback. Xandra sounds interesting, I'll have to look at that one a bit closer :)
I think I'm going to attempt it once more on my own in the meantime and if that doesn't work I'll wait for you.
@whatyouhide I tried in a new way and I nearly got it working.
To get to this point, I added a $end
token and tried to get rid of as many $empty
states as possible.
There are now only 2 errors left. It seems like the previous
and obsolete
tokens are somehow consumed prematurely.
@josevalim FYI: I quickly rebased & fixed the tests.
I will have to do one more pass over the PR and make sure all the naming etc. is correct.
@josevalim / @whatyouhide I've completed the integration.
A few points to note:
expo
already supports previous
/ obsolete
, that has no noticeable impact to the user of gettext
MapSet
=> nested listsThank you both for your time :)
:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:
@josevalim Oh wow, I was not expecting for this to get through that easy. Thanks :heart:
We just need an expo release and we can start working on the other issues. :)
Partial implementation of #215
Blocked by elixir-gettext/expo#30
This is only an initial draft and not the finished implementation. I'll be on vacation until 25th and will probably not work on this until then.