Closed mjheilmann closed 8 months ago
What about moving bulider.ex
to the subfolder bulider
too? As they share the same name.
What about moving
bulider.ex
to the subfolderbulider
too? As they share the same name.
Two reasons:
style guide suggests aligning paths and module names, so path/to/module.ex
contains defmodule Path.To.Module
. I interpret this as meaning that if Builder
was also in a folder named builder
, then the module would need to be named Builder.Builder
, and I don't want to do that.
When trying to write clean and testable modules, establishing a clean and minimal interface is important, where the exposed functionality is documented, and implementation details are hidden. Builder isn't very complicated, but when following that pattern the interface should be visible and accessible rather than inside a folder with all the implementation details.
The PR cleans up the existing functionality through the following:
rescue
clauses so that actual errors are exposed while building a reflection statefixes #17