search

elixir-grpc / grpc-reflection

elixir graph reflection support
Apache License 2.0
9 stars 6 forks source link

Elixir Library Guidelines #28

Closed mjheilmann closed 7 months ago

mjheilmann commented 8 months ago

The Elixir Library guidelines raises the problem where as a library our mixfile may be ignored by consuming projects. We should consider extending our CI run using the following text from that document:

The best practice of handling mix.lock file therefore would be to keep it in VCS, and run two different Continuous Integration (CI) > workflows: the usual deterministic one, and another one, that starts with mix deps.unlock --all and always compiles your library > and runs tests against latest versions of dependencies. The latter one might be even run nightly or otherwise recurrently to stay > notified about any possible issue in regard to dependencies updates.

mjheilmann commented 7 months ago

This may not be worth doing on a library that is not updated very often, as the unlocked CI job will only be run on PR instead of on a meaningful cadence

mjheilmann commented 7 months ago

regardless, the cost seems low and may help identify issues before they arise. A future followup to this could be retesting with multiple versions similar to libs that support multiple Elixir versions.