elixir-grpc / grpc-reflection

elixir graph reflection support
Apache License 2.0
9 stars 6 forks source link

protobuf_generate and FileDescriptor #39

Open mjheilmann opened 2 months ago

mjheilmann commented 2 months ago

We have code to compensate for the service definitions of protobuf_generate being a FileDescriptorProto instead of a ServiceDescriptorProto. But we handle it by simply extracting the ServiceDescriptorProto and passing that into the original builder code.

When we are presented with a FileDescriptorProto, we should use it directly as a reflection payload instead of ignoring the FileDescriptorProto and simulating our own. ref