search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.38k stars 212 forks source link

ci: run interop test on PR and master branch #238

Closed wingyplus closed 2 years ago

wingyplus commented 2 years ago

The pipeline will be:

On Pull Request:

Screen Shot 2565-07-21 at 14 31 00

The interop-test-all will be skip. You can see at https://github.com/wingyplus/grpc/actions/runs/2710073388.

And when merging to master branch:

Screen Shot 2565-07-21 at 14 32 13

The interop-test will be skipped and running interop-test-all which running all version of OTP/Elixir. You can see at https://github.com/wingyplus/grpc/actions/runs/2710090462.

Closes #223

polvalente commented 2 years ago

Is this a draft because you will still add the matrix for interop on main?

wingyplus commented 2 years ago

Is this a draft because you will still add the matrix for interop on main?

Yes. I still working on it. :)

wingyplus commented 2 years ago

@polvalente This PR is ready to review. I explain the detail in the PR description above. Feel free to comment. :)

wingyplus commented 2 years ago

I guess that we don't need cron_ci.yaml since it run every commit that merge to master branch?

polvalente commented 2 years ago

I guess that we don't need cron_ci.yaml since it run every commit that merge to master branch?

Yes. We can just rework the main workflow to run whatever is missing from the workflow.

Perhaps we can get rid of that .ci directory and script as well