Replace tuple style supervisor child_spec with map on cowboy adapter

elixir-grpc / grpc

An Elixir implementation of gRPC

https://hex.pm/packages/grpc

Apache License 2.0

1.38k stars 212 forks source link

Closed prihandi closed 1 year ago

prihandi commented 2 years ago

PR for #265 @polvalente

Changing child_spec format/type from Supervisor.Spec.spec() (a tuple) to Supervisor.child_spec() (a map)
Updating test case

prihandi commented 2 years ago

I see CI pipeline failed on dialyzer check because current :ranch.child_spec will never return a map,

Should I suppress dialyzer warning for this?

polvalente commented 2 years ago

I see CI pipeline failed on dialyzer check because current :ranch.child_spec will never return a map,

Should I suppress dialyzer warning for this?

Does the code allow for returning a map, though?

prihandi commented 2 years ago

Yes, for newer version of :ranch

polvalente commented 2 years ago

Looks like this PR should also update Ranch