search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.36k stars 210 forks source link

fix: restore deprecated interceptor modules #292

Closed wingyplus closed 1 year ago

wingyplus commented 1 year ago

I found the compilation warning in interop tests since PR #289 was merged. Because of GRPC Prometheus didn't change to use the new interceptor module. And it's suddenly breaking changes. So I propose to bring it back but add the deprecated module to it. The rest topic is discussing when to remove it. :)

polvalente commented 1 year ago

Although this makes sense, I'm not sure if the overhead of maintaining both versions is worth it. I think a PR for grpc-prometheus updating it instead is the better approach.

wingyplus commented 1 year ago

Unfortunately. The upcoming version would break my codebase if this PR is not applied. But it's easy to change. :)

For the grpc prometheus, we may need this library to release before changing it since it's an external library.

polvalente commented 1 year ago

We'll probably deprecate the Prometheus library :)

I'll merge this. I think it's nice to warn for at least 1 version on the deprecation.

wingyplus commented 1 year ago

We'll probably deprecate the Prometheus library :)

I'll merge this. I think it's nice to warn for at least 1 version on the deprecation.

Agreed. :)