Closed wingyplus closed 1 year ago
I think we can remove this, but perhaps @tony612 has a reason to keep it. Although we need to update grpc-prometheus in this regard as well, so perhaps an issue on the repo would be welcome.
@polvalente The issue is open. 🙇
I found the prometheus_ex
is quite too old. They didn't update the code for a long time (from https://github.com/deadtrickster/prometheus.ex). I start thinking that we should not keep it or we should find another way to tackle it (like #229).
Let's discuss this on the other repo :)
I think this should be inside the main library. Maybe being handled via https://github.com/elixir-grpc/grpc/issues/264 or https://github.com/elixir-grpc/grpc/issues/229
@sleipnir That's what I suggested. #229 can be used for this together with TelemetryMetricsPrometheus
@polvalente Sorry I didn't see your suggestion before
I think it's still used? https://github.com/elixir-grpc/grpc/blob/master/interop/lib/interop/endpoint.ex
@tony612 it's used in that sense, but no interop tests actually use it. I think it's fine for us to remove it for now so we can use Elixir 1.14 properly in CI.
I see the interop test use grpc prometheus package but I didn't see we use it to measure anything. And I found that it can be compile on my local machine with Elixir 1.14.2/OTP 25 due to error:
I guess that it's because of too old prometheus_ex library. So if we didn't use it, I purpose to removing it from the code base.
What do you think?