search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.36k stars 210 forks source link

Add support for ranch_tcp opts: ip, ipv6_v6only, inet, inet6 #308

Closed Nezteb closed 1 year ago

Nezteb commented 1 year ago

Addresses https://github.com/elixir-grpc/grpc/issues/305

It's a bit awkward because ranch_tcp's listen options are all keyword tuples except for :inet and :inet6, so I borrowed plug_cowboy's method of passing the network atoms: https://github.com/elixir-plug/plug_cowboy/blob/v2.6.0/lib/plug/cowboy.ex#L360-L361

polvalente commented 1 year ago

Please run the formatter so we can merge :)

Nezteb commented 1 year ago
Screenshot 2023-03-14 at 12 50 54 AM

@polvalente That's odd, the formatter passes on my machine. 😅

polvalente commented 1 year ago
Screenshot 2023-03-14 at 12 50 54 AM

@polvalente That's odd, the formatter passes on my machine. 😅

I think you need to run with Elixir 1.14 (the same as CI)

Nezteb commented 1 year ago

I think you need to run with Elixir 1.14 (the same as CI)

Oh, the .tool-versions file specified 1.13 so that's what my asdf install was using. 😄

EDIT: Okay format is fixed; I also bumped the Elixir versions for asdf and the Mix project to match what CI is using.