search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.36k stars 210 forks source link

Add client request to telemetry metadata #324

Closed ssepml closed 7 months ago

ssepml commented 1 year ago

Description

Having the actual client request in the telemetry event can be useful to cover more use cases, e.g. if you want to log specifics of the requests you are doing.

NOTE: Not sure if this was considered and discarded already so I just went ahead and created the PR as this would be helpful for my use case.

ssepml commented 1 year ago

@polvalente I added some asserts as you suggested. Though I only asserted some of the fields, specially for the stream. If you have something specific in mind, I can add it.

ssepml commented 1 year ago

Just checking up, is there anything else I can do to move this forward?

ssepml commented 10 months ago

Hi, any chance to get a second look at this? It would be great to have this included.

ssepml commented 9 months ago

Hi @polvalente @sleipnir , thanks for the approvals! Just for my information, is there anything else that needs to happen before this gets merged?

sleipnir commented 9 months ago

ping @polvalente

polvalente commented 9 months ago

This is on my to-do list :) Hopefully I'll get to it by next week.

ssepml commented 8 months ago

@polvalente I apologize if I'm being pushy, but are there any news on this?