search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.39k stars 212 forks source link

Replace deprecated Logger.warn with Logger.warning #338

Closed Nezteb closed 10 months ago

Nezteb commented 10 months ago

Description

Logger.warn was deprecated in Elixir 1.15, so compiling projects with elixir-grpc on 1.15 or higher produces output like this:

==> grpc
Compiling 1 file (.erl)
Compiling 36 files (.ex)
warning: Logger.warn/1 is deprecated. Use Logger.warning/2 instead
  lib/grpc/server/supervisor.ex:110: GRPC.Server.Supervisor.child_spec/3

warning: Logger.warn/1 is deprecated. Use Logger.warning/2 instead
  lib/grpc/transport/http2.ex:96: GRPC.Transport.HTTP2.append_encoding/2

warning: Logger.warn/1 is deprecated. Use Logger.warning/2 instead
  lib/grpc/server/adapters/cowboy/handler.ex:170: GRPC.Server.Adapters.Cowboy.Handler.info/3

warning: Logger.warn/1 is deprecated. Use Logger.warning/2 instead
  lib/grpc/server/adapters/cowboy/handler.ex:461: GRPC.Server.Adapters.Cowboy.Handler.extract_subtype/1

This is just a quick CMD+SHIFT+F to replace all instances of Logger.warn with Logger.warning, nothing crazy.

Note

I also see warnings like below, but I haven't looked into those:

warning: Protobuf.Decoder.decode/2 is undefined (module Protobuf.Decoder is not available or is yet to be defined)
  lib/grpc/codec/web_text.ex:27: GRPC.Codec.WebText.decode/2

warning: Protobuf.Encoder.encode/1 is undefined (module Protobuf.Encoder is not available or is yet to be defined)
  lib/grpc/codec/web_text.ex:9: GRPC.Codec.WebText.encode/1