search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.36k stars 210 forks source link

Use new logger standard #365

Closed mpmiszczyk closed 1 month ago

mpmiszczyk commented 1 month ago

I'm really sorry @polvalente , it was an miss-click on my part.

As you can see we are maintaining a for of this lib. And I tried an simple update and created PR in the incorrect repo. Basically, this time all we needed was upgrade from Logger.warn to Logger.warning - something that I think you already did (sees so, looking at your master, but my diff still shows otherwise :confused: - will check it out).

Regardles, it's awesome that the lib is being worked on :tada: I need to check our diffes, maybe drop the fork :crossed_fingers: , and share anything of interest what we came up with.

Again, sorry for not necessary ping, thanks for the CR, and till next PR :wave:

polvalente commented 1 month ago

No worries! If you guys wanna upstream the changes to hopefully drop the fork, we can discuss things over on the Elixir Slack #grpc channel or via issues here :)