search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.36k stars 210 forks source link

improve docs and specs for `Cowboy.Handler` #374

Closed beligante closed 1 week ago

beligante commented 1 week ago

Hello Hello Folks!

I'm working on add a fix for: https://github.com/elixir-grpc/grpc/issues/184 and I had a hard time understanding the whole scope of all functions. While studying them, I thought it could be interesting add some specs, docs and love to them. This is mainly to help others to future contributions. Any feedback is welcomed.

sleipnir commented 1 week ago

I approved with a small change request

beligante commented 1 week ago

I approved with a small change request

Thanks a lot for the quick review

sleipnir commented 1 week ago

Thanks for working on this @beligante