search

elixir-grpc / grpc

An Elixir implementation of gRPC
https://hex.pm/packages/grpc
Apache License 2.0
1.39k stars 212 forks source link

Allow client settings opt on mint adapter #378

Closed beligante closed 2 months ago

beligante commented 3 months ago

Hey Team, I've been actively working on this: https://github.com/elixir-grpc/grpc/issues/307 but so far no good results.

Tho, I've noticed that with a few tweaks in the configs, it's possible to improve the Mint adapter performance by 2x (which still slow if compared with gun, but it's a quick win)

This PR aims to accept a new option when starting the connection where it's possible to pass Mint's client settings options and also setting a bigger window size as default (I got these values from Gun )

I also have a branch where , with the supposer of benchee I can compare the improvement on speed

https://github.com/beligante/grpc/pull/4

sleipnir commented 2 months ago

Thank you @beligante You pretend to follow soon with https://github.com/elixir-grpc/grpc/issues/377 ? I think we are accumulating enough in main to generate a new version. But it's very interesting and if we work on it quickly we can wait.

beligante commented 2 months ago

Thank you @beligante You pretend to follow soon with https://github.com/elixir-grpc/grpc/issues/377 ? I think we are accumulating enough in main to generate a new version. But it's very interesting and if we work on it quickly we can wait.

Yup! I've finished the code changes already, I'm working on some tests. Probably later today