search

elixir-inspector / ua_inspector

User agent parser library
Apache License 2.0
125 stars 23 forks source link

Help adding Container Runtime User-Agents #29

Closed josegomezr closed 2 years ago

josegomezr commented 2 years ago

I'd like to contribute some new regexes so ua_inspector can detect container runtimes (docker, buildah, and friends).

My journey started on Plausible, and now I'm pointed to this repo (see plausible/analytics#2078),

How can I contribute the new regexes?

mneudert commented 2 years ago

The next (and final) part of your journey is matomo-org/device-detector where the regex sources are fetched from.

I would suggest to open an issue there (ideally with full example agents). If you want to try a pull request yourself I think the appropriate places would be regexes/client/libraries.yml for the regexes and Tests/Parser/Client/fixtures/library.yml for the test agents.

josegomezr commented 2 years ago

Thanks @mneudert ! Will continue my way upstream! :mage:

josegomezr commented 2 years ago

went though and it's merged! :partying_face: may I ask, when is the next release so the changes upstream are reflected here too?

mneudert commented 2 years ago

Next release will be done once I untangled my current mess of integrating the client hints into all the required places without going insane or trying to rewrite everything before a working release is available :grimacing:

josegomezr commented 2 years ago

Good luck then!

If you want an extra pair of completely Elixir-ignorant-yet-very-enthusiastic refactoring hands. Lmk!