search

elixir-lang / elixir-lang.github.com

Website for Elixir
elixir-lang.org
354 stars 822 forks source link

Production routing table config uses `config_env` (#1) #1536

Closed chrissimon-au closed 3 years ago

chrissimon-au commented 3 years ago

Mix.env() is not available in runtime.exs, and it's not clear from the text where the production routing table should go. This clarifies that it should be in runtime.exs and demonstrates the use of config_env() (instead of Mix.env())

Fixes #1535.

I'm not sure if overwriting the config is idiomatic, or if the default single entry routing table should be in a non-prod check?

josevalim commented 3 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: