search

elixir-lang / elixir

Elixir is a dynamic, functional language for building scalable and maintainable applications
https://elixir-lang.org/
Apache License 2.0
24.54k stars 3.38k forks source link

Deprecate Enum.partition in favor of Enum.split_with #4996

Closed josevalim closed 8 years ago

josevalim commented 8 years ago

Enum.partition should be soft-deprecated. Which means we will add a @doc false and leave a TODO so we can emit warnings on version 1.5 or later.

The reason for the renaming is that GenStage will introduce a particular meaning to partitions which we want to avoid mixing up with Enum.partition.

whatyouhide commented 8 years ago

I can tackle this.

josevalim commented 8 years ago

All yours!

tsubery commented 7 years ago

Instead of @doc false we can mention this function has been renamed. It would have saved me few minutes of confusion.

josevalim commented 7 years ago

That's a good point. Because right now we don't warn as well, so it is clearly hard to know its purpose. @whatyouhide, @lexmag: in the future, let's keep the docs around until we add a warning (no need to revisit stuff we have already deprecated though).

breakliu commented 6 years ago

Just find this...