search

elixir-lang / gen_stage

Producer and consumer actors with back-pressure for Elixir
http://hexdocs.pm/gen_stage
1.51k stars 192 forks source link

Link required for ConsumerSupervisor? #229

Closed axelson closed 5 years ago

axelson commented 5 years ago

When you use module-based ConsumerSupervisor, are the requirements for the start_link/2 documented anywhere? I've found that if the process that you start is not linked to the process that is running the ConsumerSupervisor that it is never removed from the list of children and you stop processing events. I realize that the "link" is implied because the function is defined as start_link but I don't see it explicitly documented anywhere.

josevalim commented 5 years ago

It is not documented I believe but that’s a requirement for ALL supervisors. Can you please send a PR? --

José Valim www.plataformatec.com.br Skype: jv.ptec Founder and Director of R&D

axelson commented 5 years ago

Yeah very true. This is the first supervisor I've implemented so I didn't realize this detail. I'll send a doc PR 👍

josevalim commented 5 years ago

Closing in favor of the PR, thanks!