search

elixir-lsp / coc-elixir

Elixir language server extension based on elixir-ls for coc.nvim
MIT License
168 stars 11 forks source link

Upgrade to elixir-ls v0.7 #52

Closed bigardone closed 3 years ago

bigardone commented 3 years ago

👋🏼 Upgrades de language server to its latest version (v0.7) 😄

https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.7.0

gcauchon commented 3 years ago

Now that Erlang/OTP 24.0.1 is out and Elixir 1.12.0 was released, the extension is broken when the codebase is upgraded. Configuring elixir.pathToElixirLS to v0.7 works so I think it's safe to merge the elixir-ls sub-module upgrade!

amiralies commented 3 years ago

Sorry for being late, i will upgrade soon

On Sat, May 22, 2021, 12:08 AM Guillaume Cauchon @.***> wrote:

Now that Erlang/OTP 24.0.1 is out and Elixir 1.12.0 was released, the extension is broken when the codebase is upgraded. Configuring elixir.pathToElixirLS to v0.7 works so I thing it's safe to merge the upgrade!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elixir-lsp/coc-elixir/pull/52#issuecomment-846205752, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFSIE5AZHHLIC33LNIB5TTO2ZEHANCNFSM42UW2FGA .

gcauchon commented 3 years ago

Sorry for being late, i will upgrade soon

Considering the OTP autoconf fix was released yesterday and 1.12 released today, I don’t think you are "late". On the contrary, thank you for maintaining an extension I use every day in my neovim setup 😃

amiralies commented 3 years ago

Thank you for the PR. I've decided to do not keep language server source code in this repo so the submodule is removed. (the npm version still has bundled langauge server from elixir-ls repo's release page). I may revert this change in future if i had time to automate the release.

bigardone commented 3 years ago

No worries, it is much better now! 🙌🏼