Closed pinarpink closed 3 years ago
Great! After discussion with @evescat, there is more to discuss:
My notification - this should be just several upcoming notifications, right?
My projects - this lists all projects a) I own b) I am local custodian c) I am listed in project's personnel or local custodian - this might have two boxes (My projects and Projects I Work On/I am part of/...)
grey box with "DAta Infromation SYstem" is kind of boring. What about to add a picture/ logo and a catch phrase/headline - "DAta Information SYstem for accountability under the GDPR"?
there might be Search box with placeholder "Search (Projects, Datasets, Data Declarations, ...)" for super quick navigation.
I like the ideas very much!
Regarding the search box - @neoflex, is running the query over different models feasible in solr?
The shortcuts "add new project" and "add new dataset" could be included in the boxes on the left, e.g:
@vildead @jLebioda both scrshots look great!! I vote for add buttons to be located in respective boxes (as in Jacek's scrshot). I propose to rename " Upcoming events" to either "Notifications" or "Expiry Alerts"
@jLebioda @vildead is there already a branch for this? I am wondering if it is doable (without the quick search.) before the 19 May workshop?
I will push the branch in a few minutes
Sure, I will do my best
The feature will be developed on 150-new-dashboard branch (https://github.com/elixir-luxembourg/daisy/tree/150-new-dashboard)
Currently it looks like that:
Collecting all the expiration events for the user might be costly - we might want to avoid having heavy code on index page; possible it could be calculated once per day as a celery task or cron job. BTW, would it be a brand new feature? I tried to find some code related to getting the events but I couldn't find any
@jLebioda hey! that was quick.
In tasks.py
we had two tasks data_storage_expiry_notifications
and document_expiry_notifications
that could be configured to run periodically. The documentation for running them is in the "Setting up reminders" section of the deployment guide. These two periodic tasks generate Notification entities. I'd say record update notifications are a bit too much, I did not even know update notifications were generated. The Notifications are displayed in the notifications page on the right-top menu.
I'd say let's comment out the search boxes for now. I actually hope that trainees can use the search pages and give us feedback on those.
@jLebioda I had a closer look, there's quite a bit stale code wrt notifications, mail send etc, which has not been tested. My vote is to leave out notifications from the dashboard for now.
OK, so I'll just hide the right-hand side.
In effect, we'd have:
@jLebioda agreed!
added a small help block to maintain the alignment
@jLebioda You were ahead of me with the user guide link. Looks very good!
already done
Is your feature request related to a problem? Please describe. Currently the user dashboard includes boxes that list things like:
Based on our DAISY use experience with LCSB users, we can say current items in dashboard do not make sense to the regular user.
Describe the solution requested
We propose that the dash board includes, instead the following lists:
Describe possible alternatives
This issue should be discussed among team before starting with implementation.
Other info context