merging the node dependencies in the service docker image

elixir-luxembourg / daisy

Data Information System (DAISY) is a data bookkeeping application designed to help Biomedical Research institutions with their GDPR compliance.

GNU Affero General Public License v3.0

12 stars 10 forks source link

merging the node dependencies in the service docker image #464

Closed HesamKorki closed 9 months ago

HesamKorki commented 9 months ago

This will simplify the deployment of Daisy + it makes the published docker image usable as a whole

vildead commented 9 months ago

I am unable to properly review this MR - not enough technical skills/knowledge to to that. Lets please rely on review from @Fancien ;)

HesamKorki commented 9 months ago

It seems to be working, I just hope that upgrade node from 16 to 18 will not cause issues later on.

The README can be slightly updated though, there is no need to say that we need to install wget in line 61 as the dockerfile now installs it.

You're right. It's addressed in the latest commit. Thanks for the review