search

elixir-makeup / makeup_elixir

Elixir lexer for Makeup
BSD 2-Clause "Simplified" License
33 stars 12 forks source link

Make extra whitespace part of the prompt #2

Closed josevalim closed 6 years ago

josevalim commented 6 years ago

If you could do a new release it would be awesome!

PS: Good job on the test suite!

tmbb commented 6 years ago

If you could do a new release it would be awesome!

I'll do a new release when I get home

PS: Good job on the test suite!

Thanks, but why do you remark on it? It's quite incomplete and mostly error-driven (I found something I didn't like, updated the lexer and added the "weird" examples as a test case). It doesn't cover all rules yet. Measuring text coverage for a NimbleParsec parser doesn't seem that easy though 😂.

josevalim commented 6 years ago

Thanks, but why do you remark on it?

Because I could add a new test in 10 seconds. :) I remember this is one of the topics you were reluctant about. Even if it doesn't have good coverage now, it will allow you to add test cases as you perform bug fixes.

tmbb commented 6 years ago

If you could do a new release it would be awesome!

It is now officially awesome.