search

elixir-makeup / makeup_elixir

Elixir lexer for Makeup
BSD 2-Clause "Simplified" License
33 stars 12 forks source link

highlight calls to erlang modules as modules #26

Closed the-mikedavis closed 3 years ago

the-mikedavis commented 3 years ago

:wave: hiya!

Following up on https://github.com/elixir-lang/tree-sitter-elixir/pull/5#issuecomment-941556251:

This PR adds a post-processing step that transforms regular atoms to be modules (:name_classes) when they're part on the left-hand-side of a . operator, so a call of a function on an erlang module highlights the same as a call on an Elixir module.

I'm pretty new to the makeup_elixir codebase so this might not be the correct place to put this transformation. Let me know!

cc: @jonatanklosko

josevalim commented 3 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

tmbb commented 3 years ago

Kinda late to the party, but I agree with this. I'd have handled the transformation exactly the same way.