search

elixir-makeup / makeup_erlang

Erlang lexer for Makeup
3 stars 6 forks source link

Parse tabs correctly #29

Closed joshprice closed 2 months ago

joshprice commented 2 months ago

I don't support tabs and certainly not mixed with spaces but this should not produce errors.

Note: not sure what \s is supposed to be matching? worth double checking whether it's really needed.

Fixes #28

josevalim commented 2 months ago

\s is a regular whitespace.

josevalim commented 2 months ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

joshprice commented 2 months ago

In regex, that makes sense but confused about the usage here. Is \s matching a space here, as it clearly doesn't match tabs?

josevalim commented 2 months ago

Yes, it is matching a single space: ?\s == 32.

I was going to publish a new version but i forgot to push v1.0.0 from the machine when i released it. So i will have to do it from home in a week.

joshprice commented 2 months ago

Thanks for clarifying. No hurry on my end, just stumbled across it while enjoying the new OTP docs ;)