search

elixir-makeup / makeup_erlang

Erlang lexer for Makeup
3 stars 6 forks source link

Update ex_doc to 0.21.1 #5

Closed mracos closed 5 years ago

mracos commented 5 years ago

The old version of ex_doc was not fetching available lexers from Makeup.Registry

josevalim commented 5 years ago

Looks good but keep in mind that once ex_doc depends makeup_erlang, we won't be able to depend on ex_doc, we will have to do a similar schema to makeup_elixir.

josevalim commented 5 years ago

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

tmbb commented 5 years ago

we will have to do a similar schema to makeup_elixir

ExDoc will never have to depend on makeup_erlang. The whole point of lexer discovery is that ExDoc will automatically be able to detect the erlang lexer if it is installed. Because ExDoc is mostly used to document Elixir projects, I keep makeup_elixir as a dependency, but it could be made optional too.

josevalim commented 5 years ago

We plan to make ex_doc work with Erlang projects as soon as it adopts EEP48 and that’s when we will depend on it, but it is still a couple months ahead of us.