Closed adamstrickland closed 8 years ago
Thank you for point it out.
I'm thinking this issue these days, and it seems that this PR will NOT solve your problem.
This PR requires an argument mount_path
and I think this would be read from phoenix routers.
I notified that there's to print maru routes forwarded by phoenix router, and I'll do it soon.
So, I'll close this PR without merge and improve a way to show maru routes within phoenix, do you think it's feasible?
Yes, sounds good. Thanks.
I've push new task maru.routes
to master and new version will be release soon.
Found that using Maru APIs
forward
ed to by the Phoenix router would get confused when nested insidescope
and (or?)namespace
clauses. This PR fixes that.Example problem:
Assume the
router.ex
:and the API, in
/web/apis/mobile/v1.ex
:In this case, the router would not properly put together both the
scope
andnamespace
path components. In the above example, the proper, fully-qualified path should be/api/mob/v1/bars
, butMaru.Builder.Routers.generate
was only producing/bars
.