search

elixir-maru / maru

Elixir RESTful Framework
https://maru.readme.io
BSD 3-Clause "New" or "Revised" License
1.32k stars 84 forks source link

Don't rely on `Mix` module being present #72

Closed brandonparsons closed 7 years ago

brandonparsons commented 7 years ago

Maru currently causes applications to break if using Distillery to do releases, as it assumes Mix.env can be called from app code.

This removes that assumption, and instructs the user to configure maru appropriately in the test environment.

falood commented 7 years ago

Hi @brandonparsons Thank you very much, but I really want to know what error you get with distillery in current codebase. For the test condition, somebody run test under other environment not :test, so I add the config to custom it, by default, I want to treat the :test env as maru_test: true, and for others set maru_test to false. so I really want to fix the current issue. link #70

brandonparsons commented 7 years ago

Commented in #70 .

Let me know if you find a solution other than this pull request. If not, please ping me when this is merged!