search

elixir-maru / maru

Elixir RESTful Framework
https://maru.readme.io
BSD 3-Clause "New" or "Revised" License
1.32k stars 84 forks source link

Upgrade to Cowboy 2 #93

Closed efcasado closed 6 years ago

efcasado commented 6 years ago

This pull-request is about upgrading Maru to use the latest major version of Cowboy (i.e. 2.X).

https://ninenines.eu/articles/cowboy-2.0.0/

The Plug upgrade is just a byproduct of upgrading Cowboy. The Cowboy2 adapter is new in Plug 1.5.

efcasado commented 6 years ago

Looks like Cowboy 2 does not like Erlang/OTP 18.

falood commented 6 years ago

Hi @efcasado I did https://github.com/elixir-maru/maru/commit/092b46a4852a0ed068bc95d8af797d6755ba4a81 just now, I think we don't need to change the code, plug v1.5 will works for cowboy 1.x and 2.x. Thank you 🙂

efcasado commented 6 years ago

Cool!

No, you won't need to change code. What I meant is that Cowboy 2.X does not compile using Erlang/OTP18. Not a big deal, though.

Looking forward to using this latest version of Maru 😄

falood commented 6 years ago

I have remove otp 18 support from travis script, let's deprecate otp18 🙂 will bump a version asap