Integration test failed with httpstat.us

elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱

Apache License 2.0

1.36k stars 112 forks source link

Integration test failed with httpstat.us #265

Closed xinz closed 2 years ago

xinz commented 4 years ago

Hello,

Since httpstat.us site is using HTTP/2 now, please see this issue for details, the server side change breaks the current integration tests, do we have any idea/plan about it?

whatyouhide commented 4 years ago

Not much to do. This is becoming annoying to maintain as more of this kind of websites add support for HTTP/2. For now, I added a commit (https://github.com/elixir-mint/mint/commit/33baa71bb6bfb2d05c27b603cfac8b7798c11450) that skips those tests.

@ericmj do you want to remove these tests altogether?

ericmj commented 4 years ago

We should probably set up local servers using plug/cowboy instead and drop the integration tests that rely on external services.

EDIT: I don't want to drop the tests since they test important behavior, but we should see if it's feasible to replace the external servers with local servers.