elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱

Apache License 2.0

1.36k stars 106 forks source link

Make get_socket/1 public API #310

Closed lukebakken closed 3 years ago

lukebakken commented 3 years ago

309

cc @ericmj

ericmj commented 3 years ago

The same change should be done to Mint.HTTP1.get_socket/1 and Mint.HTTP2.get_socket/1 as well.

lukebakken commented 3 years ago

@ericmj @whatyouhide these changes will be released as version 1.3.0, correct? Should I get CHANGELOG.md entries for this PR here as well?

whatyouhide commented 3 years ago

@lukebakken we're not sure when we will release changes, it depends on what other features are pending and a few other factors. Don't change the CHANGELOG, we'll take care of it when we cut a release, thanks! 💟