search

elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱
Apache License 2.0
1.36k stars 112 forks source link

Filter options incompatible with TLS 1.3 #314

Closed lukebakken closed 3 years ago

lukebakken commented 3 years ago

See #313

lukebakken commented 3 years ago

@ericmj all set for re-review. Thanks.

lukebakken commented 3 years ago

@ericmj are we waiting on another review? Otherwise, if you have a sec please merge. Going to start on #316

ericmj commented 3 years ago

Yes, we want two reviews before merging.

lukebakken commented 3 years ago

FWIW, my finch PR (https://github.com/keathley/finch/pull/133) depends on this PR and a release of mint version 1.3.

Specifically, it's this test: https://github.com/keathley/finch/pull/133/files#diff-4493940c19991b61e8ce2b3e92a72554fc257cf117355c0129bfe353a84f3b08R55-R70

Here's the error from mint that you get when you only specify TLS 1.3... I don't remember if I shared this or not:

{:error, %Mint.TransportError{reason: {:options, :dependency, {:reuse_sessions, {:versions, [:tlsv1, :"tlsv1.1", :"tlsv1.2"]}}}}}