Properly close socket on erroneous connection

elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱

Apache License 2.0

1.36k stars 112 forks source link

Properly close socket on erroneous connection #367

Closed bitberry-dev closed 2 years ago

bitberry-dev commented 2 years ago

Fix #365

whatyouhide commented 2 years ago

Thank you @bitberry-dev! 💟

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 87c221dc4ab03287d2a7964d8df458e43c83410f-PR-367

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 85.052%

Files with Coverage Reduction	New Missed Lines	%
lib/mint/http2.ex	2	88.56%
<!--	Total:	2		-->

Totals
Change from base Build 90099586704e7c6e2e190c5b127b7db9a36cffe8:	0.0%
Covered Lines:	1320
Relevant Lines:	1552

💛 - Coveralls

epinault commented 2 years ago

any chance to get this released in 1.4.3? I see the fix was in 13 days ago and I believe it will fix similar issue we are noticing with socket closed error

epinault commented 2 years ago

also could this be an issue for http as well?

bitberry-dev commented 2 years ago

also could this be an issue for http as well?

Nope, http1 module is fine

epinault commented 2 years ago

Hmm. I am seeing issues with Finch/Mint around socket closed that I don't see when using other things like hackney with Tesla .

I was thinking a service we run had issues but even so, hackney is ok with it but with Finch/Mint I see some socket closed happening .. I am wondering if there is a path still where that can happen