elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱
Apache License 2.0
1.36k stars 106 forks source link

Check argument types on `HTTP1.request/5` #375

Closed britto closed 1 year ago

britto commented 1 year ago

The same way we do in HTTP2.request/5. Noticed it through dialyzer while passing a map of headers instead of a list.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4749efbeb0e1fbcda004b00dd31258ca9aeb4ec8-PR-375


Files with Coverage Reduction New Missed Lines %
test/support/mint/http1/test_server.ex 1 84.62%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build a947ca3e4c60d3bf0757ab457c465f949819ed71: -0.06%
Covered Lines: 1319
Relevant Lines: 1552

💛 - Coveralls
whatyouhide commented 1 year ago

Thanks @britto 💟