Closed josevalim closed 5 months ago
josevalim
commented
5 months ago It would be fantastic to get a new minor version with this change to address this: https://github.com/livebook-dev/livebook/issues/2642
But we can also depend on main if merged. :)
coveralls
commented
5 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/mint/core/transport/ssl.ex | 2 | 4 | 50.0% | ||
| <!-- | Total: | 2 | 4 | 50.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/mint/core/transport/ssl.ex | 1 | 85.82% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build f83b897ec3808cd871fa83140ac9d8aa5169b4c6: | -0.2% |
| Covered Lines: | 1276 |
| Relevant Lines: | 1457 |
coveralls
commented
5 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/mint/core/transport/ssl.ex | 2 | 4 | 50.0% | ||
| <!-- | Total: | 2 | 4 | 50.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/mint/core/transport/ssl.ex | 1 | 85.82% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build f83b897ec3808cd871fa83140ac9d8aa5169b4c6: | -0.2% |
| Covered Lines: | 1276 |
| Relevant Lines: | 1457 |
whatyouhide
commented
5 months ago @josevalim 1.6.1 is out 🙃
wojtekmach
commented
5 months ago @whatyouhide v1.6.1 is out on GitHub but looks like not yet on Hex!
wojtekmach
commented
5 months ago Thanks! I'm updating Finch accordingly: https://github.com/sneako/finch/pull/274.
The OTP team no longer supports Erlang versions earlier than 25+, so we can assuming that
:public_key.cacerts_get/0is available and only fallback toCAStoreif not.This also solves a bug in that Req/Finch/Mint do not work inside escripts by default (because inside an escript you cannot access the priv dir of an application).