elixir-mint / mint

Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2 🌱
Apache License 2.0
1.36k stars 106 forks source link

Contributing and testing housekeeping #440

Closed kianmeng closed 4 days ago

kianmeng commented 4 days ago

List of changes:

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build d65f6218de2b0338480e3dbad688d436a946b5ed-PR-440

Details


Totals Coverage Status
Change from base Build d3070089d4d22e8062e94df1334889437658fdee: 0.0%
Covered Lines: 1275
Relevant Lines: 1459

💛 - Coveralls
kianmeng commented 4 days ago

This is a lot of different changes 🙃 In general, I'd recommend to split these out in multiple PRs next time so that we can pick and choose. I left a few blocking comments about stuff that I would prefer not to change. Thanks for the contribution!

I will close this PR and submit smaller PRs instead with the changes you intend to keep. It's easier that way.