elixir-mogrify / mogrify

Image processing in Elixir (ImageMagick command line wrapper)
MIT License
570 stars 65 forks source link

Add options structure #52

Closed GustavoCaso closed 6 years ago

GustavoCaso commented 6 years ago

Fixes #34

Is not all options added but I wanted to share the structure before adding all of them since they are a lot 💥

So far I mostly copy the logic from https://github.com/talklittle/ffmpex. Thanks @talklittle

If people are ok the structure I will add the rest of the options 😄

Also, another thing we could think about is deprecating custom method in the future once this is merged.

GustavoCaso commented 6 years ago

@talklittle, @uesteibar I have added the requested changes. Once we are happy with the changes is just a matter of including all the options and improve the documentation.

talklittle commented 6 years ago

Looks great! Thank you very much for working on this @GustavoCaso ! And thanks @uesteibar for reviewing.