search

elixir-mongo / mongodb

MongoDB driver for Elixir
Apache License 2.0
571 stars 156 forks source link

Add support for the :binary_old subtype for BSON.Binary #292

Closed skinandbones closed 5 years ago

skinandbones commented 5 years ago

The problem is discussed in Issue #290.

This PR is a work in progress. The proposed code change is working on my production dataset. Remaining is devising a test strategy. I don't think it's going to be possible to insert the old binary format into a test DB so we may need to do something else.

skinandbones commented 5 years ago

Tests added according to my understanding of the BSON spec for binary_old.

sourcelevel-bot[bot] commented 5 years ago

Hello, @skinandbones! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

ankhers commented 5 years ago

Thank you!