search

elixir-mongo / mongodb

MongoDB driver for Elixir
Apache License 2.0
571 stars 156 forks source link

Add LDAP Auth for MongoDB Enterprise #296

Closed churchie317 closed 5 years ago

churchie317 commented 5 years ago

Builds upon the 0.4.7 release.

I know this isn't a burning need in the community, but it would be super helpful if we could push this into a 0.4.8 release.

This change would extend current functionality by allowing for LDAP Authorization via passing the auth_mechanism: :plain option to the start_link function.

Thanks!

P.S. I don't expect this to be mergeable into the origin master branch. Could we create a new branch from the 0.4.7 release and merge into that?

churchie317 commented 5 years ago

Also, I'm happy to implement these changes in the > 0.5.1 releases if the community would find that helpful.

ankhers commented 5 years ago

I think the easiest thing to do would be to write this PR for the current master and then I should be able to backport the commit and do a 0.4.8 release.

Though, if you can, please avoid running mix format on the files. I know it is something that needs to be done, but it makes it harder to find what you actually changed in your PR. I would rather just run it for the entire project in one go.

sourcelevel-bot[bot] commented 5 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/ankhers/mongodb/pulls/296.